Use musl build for ARM Linux #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konstin -- Can you please review? |
konstin
approved these changes
Jul 5, 2024
charliermarsh
force-pushed
the
charlie/musl
branch
from
91ee442
to
2b93ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uv's dynamically-linked ARM Linux build is only compatible with
manylinux_2_28(we can't build Ring for earlier versions). You can see that we dual-tag the musl build for this reason as beingmanylinux_2014-compatible. This PR moves the ARM build to use the musl build, which should resolve the compatibility issues withmanylinux_2_17.Closes #1187.