Remove redundant alias information from CLI #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed this today. Glad to see a PR already. |
bluss
reviewed
Jul 18, 2024
rye/src/cli/fetch.rs
Outdated
| @@ -10,7 +10,7 @@ use crate::pyproject::PyProject; | |||
| use crate::sources::py::PythonVersionRequest; | |||
| use crate::utils::CommandOutput; | |||
|
|
|||
| /// Fetches a Python interpreter for the local machine. This is an alias of `rye toolchain fetch`. | |||
| /// Fetches a Python interpreter for the local machine | |||
There was a problem hiding this comment.
This note is also visible in rye -h for fetch. Does that change too with this PR, or does it come from somewhere else?
See also rye install, rye uninstall.
There was a problem hiding this comment.
It looks that changing this docstring for this struct affects every place where it's referenced.
Remove redundant information about aliases
piotrgredowski
force-pushed
the
piotrgredowski-patch-1
branch
from
30e3ce8
to
ec774a9
Compare
charliermarsh
approved these changes
Jul 20, 2024
charliermarsh
approved these changes
Jul 20, 2024
charliermarsh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant information about
toolchain fetchbeing an alias oftoolchain fetch.