-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerPC page size issue with released binaries #6528
Comments
Is this a duplicate of #4647 but for our distributions? |
Yes, sorry I missed that. It's also not clear that issue is with the released binaries from the GitHub releases page or something else, but I think aarch64 has the same issue with some distributions but I'm not sure. This is an issue with the ppc64le binaries on the releases page. |
Any idea how to approach fixing this? Do we need to set a different page size during build? |
I'd say just have a note in the readme, release notes, or the binary file name to indicate the binary expects 4k pages on ppc64 (and probably arm) where 4k isn't the default. As for how to have your build environment run with a 64k page size when you likely aren't running on bare metal, I don't know. Can Docker allow running with different page sizes? |
We do this uv/.github/workflows/build-binaries.yml Line 574 in e097f94
per |
That looks good for ARM devices. |
Same results on an IBM Power9 server, both the downloaded artifact from the release page and the pip-installed binary fail in jemalloc. Have not yet tried to build from the source, but this is a blocker for using
|
Maybe build from source and cache the binary for your CI? The build is pretty simple and straightforward. |
Looks like this was fixed for ppc64le in Ruff using the same build flags that are being passed to maturin for aarch64. Could the same fix be applied to uv? |
I'm happy to review a PR and see if it fixes it. |
Yeah we should apply those changes. I actually thought we already had them in the build script, but it turns out they're only applied to some other architectures and not PowerPC. |
## Summary Add maturin build flag to set 64kb page size on PPC64 and PPC64LE architectures. Not aware of modern systems that use 4kb pages. Resolves astral-sh#6528 # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Author: Tom <[email protected]> # Date: Wed Sep 11 11:10:13 2024 -0400 # # On branch main # Your branch and 'origin/main' have diverged, # and have 1 and 2 different commits each, respectively. # (use "git pull" to merge the remote branch into yours) # # Changes to be committed: # modified: build-binaries.yml #
The released binaries for powerpc64le don't run on 64k page size systems, but uv runs on those systems when compiled from source.
This may be an issue since I think most ppc64 systems use 64k as that seems to be the default. As far as I know, the discontinued Void Linux PPC and Chimera Linux are the only ppc64 systems which used 4k pages.
The text was updated successfully, but these errors were encountered: