-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust crate fs-err to v3 #8625
base: main
Are you sure you want to change the base?
Conversation
|
It looks like the message format meaningfully changed here (check out the expanded summary), so we should just make sure it's compatible with our |
Updated the snapshots — need to do so on Windows still. |
9a593fa
to
4b39a70
Compare
@@ -39,5 +39,5 @@ workspace = true | |||
|
|||
[dev-dependencies] | |||
indoc = { version = "2.0.5" } | |||
insta = { version = "1.40.0" } | |||
insta = { version = "1.40.0", features = ["filters"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
// "Caused by: Das System kann den angegebenen Pfad nicht finden. (os error 3)" | ||
// ": Das System kann den angegebenen Pfad nicht finden. (os error 3)" | ||
filters.push(( | ||
r"Caused by: .* \(os error 3\)", | ||
"Caused by: The system cannot find the path specified. (os error 3)", | ||
r"CACHEDIR.TAG`: .* \(os error 3\)", | ||
"CACHEDIR.TAG`: The system cannot find the path specified. (os error 3)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: I bet this can be simplified now that we do #8606
This PR contains the following updates:
2.11.0
->3.0.0
2.11.0
->3.0.0
Release Notes
andrewhickman/fs-err (fs-err)
v3.0.0
Compare Source
Error messages now include the original message from
std::io::Error
by default (#60). Previously this was exposed through theError::source()
method. For example, previously a message would look like:and you would have to remember to print the source, or use a library like
anyhow
to print the full chain of source errors. The new error message includes the cause by defaultNote that the original error is no longer exposed though
Error::source()
by default. If you need access to it, you can restore the previous behaviour with theexpose_original_error
feature flag.The
io_safety
feature flag has been removed, and this functionality is now always enabled on Rust versions which support it (1.63.0 and greater).Removed deprecated APIs:
File::from_options
,tokio::symlink
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.