Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate fs-err to v3 #8625

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update Rust crate fs-err to v3 #8625

wants to merge 6 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 28, 2024

This PR contains the following updates:

Package Type Update Change
fs-err dev-dependencies major 2.11.0 -> 3.0.0
fs-err workspace.dependencies major 2.11.0 -> 3.0.0

Release Notes

andrewhickman/fs-err (fs-err)

v3.0.0

Compare Source

  • Error messages now include the original message from std::io::Error by default (#​60). Previously this was exposed through the Error::source() method. For example, previously a message would look like:

    failed to open file `file.txt`
    

    and you would have to remember to print the source, or use a library like anyhow to print the full chain of source errors. The new error message includes the cause by default

    failed to open file `file.txt`: The system cannot find the file specified. (os error 2)
    

    Note that the original error is no longer exposed though Error::source() by default. If you need access to it, you can restore the previous behaviour with the expose_original_error feature flag.

  • The io_safety feature flag has been removed, and this functionality is now always enabled on Rust versions which support it (1.63.0 and greater).

  • Removed deprecated APIs: File::from_options, tokio::symlink


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the internal A refactor or improvement that is not user-facing label Oct 28, 2024
Copy link
Contributor Author

renovate bot commented Oct 28, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 3.0.0
    Updating crates.io index
error: failed to select a version for the requirement `fs-err = "^2.11.0"`
candidate versions found which didn't match: 3.0.0
location searched: crates.io index
required by package `tracing-durations-export v0.3.0`
    ... which satisfies dependency `tracing-durations-export = "^0.3.0"` (locked to 0.3.0) of package `uv v0.4.27 (/tmp/renovate/repos/github/astral-sh/uv/crates/uv)`

@charliermarsh
Copy link
Member

It looks like the message format meaningfully changed here (check out the expanded summary), so we should just make sure it's compatible with our anyhow use.

@zanieb
Copy link
Member

zanieb commented Oct 28, 2024

Updated the snapshots — need to do so on Windows still.

@@ -39,5 +39,5 @@ workspace = true

[dev-dependencies]
indoc = { version = "2.0.5" }
insta = { version = "1.40.0" }
insta = { version = "1.40.0", features = ["filters"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Comment on lines -1035 to +1038
// "Caused by: Das System kann den angegebenen Pfad nicht finden. (os error 3)"
// ": Das System kann den angegebenen Pfad nicht finden. (os error 3)"
filters.push((
r"Caused by: .* \(os error 3\)",
"Caused by: The system cannot find the path specified. (os error 3)",
r"CACHEDIR.TAG`: .* \(os error 3\)",
"CACHEDIR.TAG`: The system cannot find the path specified. (os error 3)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: I bet this can be simplified now that we do #8606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants