Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove #egg=jwst and use release tag instead of commit hash #170

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Sep 23, 2024

@nden @tapastro I apologize for asking again, could you review this and merge

@tapastro
Copy link

We also need to remove the edit flag - I think this is the cause of the SDP env build failures.

@tapastro
Copy link

Looks reasonable now - is this sort of tag alright to use in future release workflows, or does something prevent its use when first created?

@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Sep 23, 2024

Looks reasonable now - is this sort of tag alright to use in future release workflows, or does something prevent its use when first created?

the reqs_..._stable-deps.txt is created using pip freeze in the regression test workflow (https://github.com/spacetelescope/RegressionTests/blob/02913aebf6edff5c2435408ba7837cf86ad47b6f/.github/workflows/test.yml#L219), so it uses exactly what was installed in the test environment (which is the editable install at the latest commit). Thus, I had to manually replace that line with jwst == 1.16.0 after it was pushed to PyPI

I think stasis will handle that a bit better than this system (@jhunkeler could you chime in when you have a moment?)

@tapastro
Copy link

Happy to hear how stasis will reduce friction here, though can we get this fixed merged and the files on ssb.stsci.edu updated so that SDP can begin testing?

@zacharyburnett
Copy link
Contributor Author

Unfortunately, I don't have write access to this repository and the STARS ticket I sent in this morning to get it hasn't completed yet. Besides @nden I think @jhunkeler also has access

@jhunkeler jhunkeler merged commit e8330d8 into astroconda:master Sep 23, 2024
3 checks passed
@zacharyburnett zacharyburnett deleted the fix/jwstdp-1.16.0 branch September 23, 2024 19:33
@zacharyburnett
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants