Resolve core unit test internal warning (apache#38835)

* Resolve core unit test internal warning * add back test_impersonation_subdag into deprecations_ignore.yml
astronomer · Apr 22, 2024 · abdc9ef · abdc9ef
1 parent 6962671
commit abdc9ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/core/test_core.py b/tests/core/test_core.py
@@ -136,14 +136,14 @@ def test_externally_triggered_dagrun(self, dag_maker):
 
         with dag_maker(schedule=timedelta(weeks=1)):
             task = EmptyOperator(task_id="test_externally_triggered_dag_context")
-        dag_maker.create_dagrun(
+        dr = dag_maker.create_dagrun(
             run_type=DagRunType.SCHEDULED,
             execution_date=execution_date,
             external_trigger=True,
         )
         task.run(start_date=execution_date, end_date=execution_date)
 
-        ti = TI(task=task, execution_date=execution_date)
+        ti = TI(task=task, run_id=dr.run_id)
         context = ti.get_template_context()
 
         # next_ds should be the execution date for manually triggered runs
@@ -169,14 +169,14 @@ def test_dag_params_and_task_params(self, dag_maker):
                 params={"key_2": "value_2_new", "key_3": "value_3"},
             )
             task2 = EmptyOperator(task_id="task2")
-        dag_maker.create_dagrun(
+        dr = dag_maker.create_dagrun(
             run_type=DagRunType.SCHEDULED,
             external_trigger=True,
         )
         task1.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
         task2.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
-        ti1 = TI(task=task1, execution_date=DEFAULT_DATE)
-        ti2 = TI(task=task2, execution_date=DEFAULT_DATE)
+        ti1 = TI(task=task1, run_id=dr.run_id)
+        ti2 = TI(task=task2, run_id=dr.run_id)
         context1 = ti1.get_template_context()
         context2 = ti2.get_template_context()
 

diff --git a/tests/deprecations_ignore.yml b/tests/deprecations_ignore.yml
@@ -70,8 +70,6 @@
 
 
 # Core
-- tests/core/test_core.py::TestCore::test_dag_params_and_task_params
-- tests/core/test_core.py::TestCore::test_externally_triggered_dagrun
 - tests/core/test_impersonation_tests.py::TestImpersonation::test_impersonation_subdag
 - tests/core/test_stats.py::TestCustomStatsName::test_does_not_send_stats_using_statsd_when_the_name_is_not_valid
 - tests/core/test_stats.py::TestCustomStatsName::test_does_send_stats_using_statsd_when_the_name_is_valid