Skip to content

Commit

Permalink
docs(providers/amazon): update soft_fail util TODO due to apache#33424
Browse files Browse the repository at this point in the history
  • Loading branch information
Lee-W committed Aug 31, 2023
1 parent acd8b71 commit f91fecf
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions airflow/providers/amazon/aws/sensors/batch.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from airflow.configuration import conf
from airflow.exceptions import AirflowException
from airflow.providers.amazon.aws.hooks.batch_client import BatchClientHook
from airflow.providers.amazon.aws.sensors.utils import raise_failed_or_skiping_exception
from airflow.providers.amazon.aws.triggers.batch import BatchJobTrigger
from airflow.sensors.base import BaseSensorOperator

Expand Down Expand Up @@ -117,13 +118,9 @@ def execute_complete(self, context: Context, event: dict[str, Any]) -> None:
if event["status"] != "success":
message = f"Error while running job: {event}"
# TODO: remove this if-else block when min_airflow_version is set to higher than the version that
# raise_failed_or_skiping_exception is introduced in BaseSensorOperator
if getattr(self, "raise_failed_or_skiping_exception"):
self.raise_failed_or_skiping_exception(failed_message=message)
else:
from airflow.providers.amazon.aws.sensors.utils import raise_failed_or_skiping_exception
# changed in https://github.com/apache/airflow/pull/33424 is released

raise_failed_or_skiping_exception(soft_fail=self.soft_fail, failed_message=message)
raise_failed_or_skiping_exception(soft_fail=self.soft_fail, failed_message=message)
job_id = event["job_id"]
self.log.info("Batch Job %s complete", job_id)

Expand Down

0 comments on commit f91fecf

Please sign in to comment.