Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python3.12 in test matrix #21

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Add Python3.12 in test matrix #21

merged 6 commits into from
Jun 24, 2024

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Jun 22, 2024

@marwan116
Copy link
Collaborator

@venkatajagannath @pankajastro please address the below comments and then let us:

  • merge this PR
  • rebase the changes4 branch so its PR becomes the one we provide a final code review on

Comments:

  • Update the pyproject.toml file so that classifiers includes "Programming Language :: Python :: 3.12"
  • Should we also update the pyproject.toml file so that requires-python to be >=3.8, <=3.12 ?

@pankajastro
Copy link
Collaborator Author

Comments:

  • Update the pyproject.toml file so that classifiers includes "Programming Language :: Python :: 3.12"
  • Should we also update the pyproject.toml file so that requires-python to be >=3.8, <=3.12 ?

The classifiers in the pyproject file have Python3.12, and I have addressed the second point in this PR.

@pankajastro pankajastro merged commit 8a6e2ee into main Jun 24, 2024
16 checks passed
@pankajastro pankajastro deleted the py3.12 branch June 24, 2024 15:28
@pankajastro pankajastro added this to the 1.0.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants