Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up a Ray cluster on K8, we need to provide namespace option.
The expected behavior is to pick the namespace provided in the connection (using
self.get_namespace()
) or usedefault
The code though has a bug. If the namespace is not provided in the connection, it does not use the default.
This is because the variable created in the init method is not used in the setup_ray_cluster & delete_ray_cluster methods. Instead a direct call is made to
self.get_namespace()
This PR fixes that bug