Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace bug fix #59

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Namespace bug fix #59

merged 2 commits into from
Sep 3, 2024

Conversation

venkatajagannath
Copy link
Contributor

@venkatajagannath venkatajagannath commented Sep 2, 2024

While setting up a Ray cluster on K8, we need to provide namespace option.

The expected behavior is to pick the namespace provided in the connection (using self.get_namespace()) or use default

The code though has a bug. If the namespace is not provided in the connection, it does not use the default.

This is because the variable created in the init method is not used in the setup_ray_cluster & delete_ray_cluster methods. Instead a direct call is made to self.get_namespace()

This PR fixes that bug

@venkatajagannath venkatajagannath added the bug Something isn't working label Sep 2, 2024
@venkatajagannath venkatajagannath linked an issue Sep 2, 2024 that may be closed by this pull request
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an open issue we could link to the PR? Could we please also enhance the PR description to provide some more details on what the bug was? And how we are fixing it.

This will help review easier to understand on what's getting fixed & for what reason.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (fd9807b) to head (bd4539a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   95.42%   98.16%   +2.74%     
==========================================
  Files           5        5              
  Lines         546      546              
==========================================
+ Hits          521      536      +15     
+ Misses         25       10      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@venkatajagannath venkatajagannath merged commit b496836 into main Sep 3, 2024
17 checks passed
@venkatajagannath venkatajagannath added this to the 0.2.1 milestone Sep 4, 2024
@venkatajagannath venkatajagannath deleted the namespace_bug_fix branch September 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes namespace config enhancements required
3 participants