-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add astro cli project + kind Raycluster setup instruction #83
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 5 5
Lines 564 564
=======================================
Hits 554 554
Misses 10 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on having this guide in place. Have some minor suggestions/questions inline.
Should we also log a follow-up ticket for guiding on how to deploy to Astro deployment & how to create an Airflow connection there with mounting/using the needed Kubeconfig file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the make docker-run
command & was able to successfully spin up & run a DAG.
One question for the Dockerfile and some minor nits inline.
This PR introduces several enhancements aimed at improving the setup and local testing
Docs generated HTML
Created follow-up tickets: #89 and #88