Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro cli project + kind Raycluster setup instruction #83

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Oct 25, 2024

This PR introduces several enhancements aimed at improving the setup and local testing

  • Documentation for RayCluster Setup: Added comprehensive instruction documents to facilitate the setup of RayCluster using Kind.
  • Example Connection for Local Kind RayCluster: Included an example configuration to demonstrate how to connect to a local RayCluster deployed with Kind.
  • Introduce Astro-CLI: Introduced the astro-cli Airflow project, allowing users to easily spin up Airflow and execute example DAGs from this repository.
  • Makefile: Added a Makefile that wraps astro-cli and pip commands, simplifying the process for testing local changes.

Docs generated HTML
Screenshot 2024-10-26 at 1 03 09 AM

Created follow-up tickets: #89 and #88

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (4a362a2) to head (85a5357).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files           5        5           
  Lines         564      564           
=======================================
  Hits          554      554           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on having this guide in place. Have some minor suggestions/questions inline.

Should we also log a follow-up ticket for guiding on how to deploy to Astro deployment & how to create an Airflow connection there with mounting/using the needed Kubeconfig file?

dev/Dockerfile Show resolved Hide resolved
dev/README.md Outdated Show resolved Hide resolved
dev/README.md Outdated Show resolved Hide resolved
docs/getting_started/kind_ray.rst Outdated Show resolved Hide resolved
docs/getting_started/kind_ray.rst Outdated Show resolved Hide resolved
docs/getting_started/kind_ray.rst Outdated Show resolved Hide resolved
docs/getting_started/kind_ray.rst Outdated Show resolved Hide resolved
docs/getting_started/kind_ray.rst Outdated Show resolved Hide resolved
docs/getting_started/setup.rst Outdated Show resolved Hide resolved
@pankajastro
Copy link
Collaborator Author

Should we also log a follow-up ticket for guiding on how to deploy to Astro deployment & how to create an Airflow connection there with mounting/using the needed Kubeconfig file?

Created #89 to improve contributing guide and #88 for Astro deployment guide

pankajkoti
pankajkoti previously approved these changes Oct 30, 2024
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the make docker-run command & was able to successfully spin up & run a DAG.
One question for the Dockerfile and some minor nits inline.

dev/Dockerfile Show resolved Hide resolved
docs/getting_started/code_samples.rst Outdated Show resolved Hide resolved
docs/getting_started/code_samples.rst Outdated Show resolved Hide resolved
docs/getting_started/code_samples.rst Outdated Show resolved Hide resolved
docs/getting_started/code_samples.rst Outdated Show resolved Hide resolved
docs/getting_started/code_samples.rst Outdated Show resolved Hide resolved
@pankajastro pankajastro merged commit cf599b8 into main Oct 30, 2024
17 checks passed
@pankajastro pankajastro deleted the setup branch October 30, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants