Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test and bug in load balancer wait logic #85

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Oct 28, 2024

I noticed that sometimes dag.test() does not raise an exception even when an Airflow task fails, leading to silent failures in CI jobs without any notification. To address this, I’ve added an explicit assertion to check that the DAG run state is "success" when dag.test() does not raise an exception.

Added the tool.pytest.ini_options section in pyproject.toml, including the minversion option and custom markers.

Fixed bug in the sleep logic while waiting for the load balancer to become ready

Failed detected CI: https://github.com/astronomer/astro-provider-ray/actions/runs/11560564529/job/32177695161?pr=85

closes: https://github.com/astronomer/oss-integrations-private/issues/22

@pankajastro pankajastro marked this pull request as ready for review October 28, 2024 19:36
@pankajastro pankajastro requested a review from a team as a code owner October 28, 2024 19:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (0d99128) to head (c80556e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   96.09%   98.22%   +2.13%     
==========================================
  Files           5        5              
  Lines         563      564       +1     
==========================================
+ Hits          541      554      +13     
+ Misses         22       10      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro changed the title Debug: Remove try except block Fix integration test and bug in load balancer wait logic Oct 28, 2024
@pankajastro pankajastro merged commit b6fe51b into main Oct 29, 2024
17 checks passed
@pankajastro pankajastro deleted the fix_ci branch October 29, 2024 08:57
@pankajastro pankajastro restored the fix_ci branch October 29, 2024 08:58
@pankajastro pankajastro deleted the fix_ci branch October 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants