Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable secrect detection precommit check #91

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Nov 5, 2024

Enable secret detection in pre-commit to minimize key leak

debug statements (python).....................................................Passed
fix end of files..............................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing key1.pem

mixed line ending.............................................................Passed
pretty format json............................................................Passed
trim trailing whitespace......................................................Passed
detect private key............................................................Failed
- hook id: detect-private-key
- exit code: 1

Private key found: key1.pem

detect aws credentials........................................................Failed
- hook id: detect-aws-credentials
- exit code: 2
Screenshot 2024-11-05 at 10 39 08 AM

related: https://github.com/astronomer/oss-integrations-private/issues/28

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (cf599b8) to head (b58deb5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files           5        5           
  Lines         564      564           
=======================================
  Hits          554      554           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue for this? If yes, can we add a "related: #issue number" label in the PR description? If not, I guess would be good to create an issue & link the issue to the PR description with label "related" or "closes".

@pankajastro pankajastro merged commit 5d2e992 into main Nov 5, 2024
17 checks passed
@pankajastro pankajastro deleted the secret-precommit-hook branch November 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants