Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customization of column titles capitalization when using dataframe & load_file #564

Closed
4 tasks
tatiana opened this issue Jul 25, 2022 · 0 comments · Fixed by #567
Closed
4 tasks

Support customization of column titles capitalization when using dataframe & load_file #564

tatiana opened this issue Jul 25, 2022 · 0 comments · Fixed by #567
Assignees
@tatiana
Labels
improvement Enhancement or improvement in an existing feature
Milestone
1.0.0

Comments

@tatiana
Copy link
Collaborator

tatiana commented Jul 25, 2022 •
edited
Loading

Context

To achieve a first end-to-end delivery of the Snowflake optimization:
#487
#544

There was an assumption that, to avoid issues with Snowflake mixed-capitalized column names, it was acceptable to convert all characters to uppercase. However, there are two issues with this approach:

  • it is not consistent with the dataframe decorator parameter: identifiers_as_lower
  • it does not support the use case where users may prefer to convert everything to uppercase

Proposal

The goal with this ticket is to add the following argument to both aql.dataframe and aql.load_file (snowflake-only), removing the previous identifiers_as_lower parameter:

columns_names_capitalization=["upper", "lower", "original"]

Acceptance criteria

  • Replace the aql.dataframe argument identifiers_as_lower by columns_names_capitalization
  • Add support for columns_names_capitalization when using load_file to Snowflake
  • Have tests covering these scenarios
  • Update release notes
@tatiana tatiana changed the title Allow users to decide on capitalization of column titles when using dataframe & load_file Support customization of column titles capitalization when using dataframe & load_file Jul 25, 2022
@tatiana tatiana added the improvement Enhancement or improvement in an existing feature label Jul 25, 2022
@tatiana tatiana self-assigned this Jul 25, 2022
@utkarsharma2 utkarsharma2 added this to the 1.0.0 milestone Jul 25, 2022
This was referenced Jul 25, 2022
Closed
Merged
@tatiana tatiana mentioned this issue Jul 26, 2022
Merged
tatiana pushed a commit that referenced this issue Jul 26, 2022
@utkarsharma2
Refactor 'identifiers_as_lower' to 'columns_names_capitalization' (#567)
0b9afa3 
Closes: #564

Move towards a consistency strategy to change column names' capitalisation for both dataframes and files loaded using `load_file`.
* Expose 'columns_names_capitalization' both in `aql.load_file` and `aql.dataframe`
* Remove 'identifiers_as_lower' from `aql.dataframe`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatiana tatiana

Labels
improvement Enhancement or improvement in an existing feature
Projects
None yet
Milestone
1.0.0
2 participants
@tatiana @utkarsharma2