-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix empty tag in case of custom parser (#1100)
## Description As of version 1.5.1, using a custom parser to parse a dbt project hardcodes the tags value to an empty list [] when initializing the DbtNode object. This creates issues for users utilizing the select option in the DAG with render_config, resulting in distorted DAG rendering, as shown below. <img width="1435" alt="Screenshot 2024-07-16 at 10 51 00 PM" src="https://github.com/user-attachments/assets/f6da8ce0-cd80-479f-a0ad-a537a5f2c776"> This PR parses the tag values from the project and uses them to initialize the DbtNode object. Post this change rendering appears like <img width="1473" alt="Screenshot 2024-07-17 at 7 01 53 PM" src="https://github.com/user-attachments/assets/8d15d4f0-7e4d-4808-b00d-2ac3286db5a9"> ## Related Issue(s) closes: #943 closes: #693 ## Breaking Change? No ## Checklist - [x] I have made corresponding changes to the documentation (if required) - [x] I have added tests that prove my fix is effective or that my feature works
- Loading branch information
1 parent
fd264e3
commit b25d5ea
Showing
4 changed files
with
34 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{{ config(tags=["customers"]) }} | ||
|
||
with customers as ( | ||
|
||
select * from {{ ref('stg_customers') }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters