Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set append_env to True by default #595

Closed
tatiana opened this issue Oct 12, 2023 · 0 comments · Fixed by #899
Closed

Set append_env to True by default #595

tatiana opened this issue Oct 12, 2023 · 0 comments · Fixed by #899
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc good first issue Good for newcomers priority:high High priority issues are blocking or critical issues without a workaround and large impact
Milestone
1.4.0

Comments

@tatiana
Copy link
Collaborator

tatiana commented Oct 12, 2023

As a follow-up suggestion from the Slack thread:
https://apache-airflow.slack.com/archives/C059CC42E9W/p1696942075155009

@jlaneve suggested we could set append_env to True by default, which sounds like a good idea! This way Cosmos will be consistent (LoadMethod.DBT_LS and operator's exposing environment variables).

Relates to: #593
@tatiana tatiana added the good first issue Good for newcomers label Oct 12, 2023
@tatiana tatiana added this to the 1.3.0 milestone Oct 12, 2023
@tatiana tatiana added the priority:high High priority issues are blocking or critical issues without a workaround and large impact label Oct 26, 2023
@tatiana tatiana mentioned this issue Oct 26, 2023
Closed
@tatiana tatiana added the area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc label Nov 8, 2023
@tatiana tatiana modified the milestones: 1.3.0, 1.4.0 Jan 4, 2024
@tatiana tatiana mentioned this issue Mar 21, 2024
Merged
tatiana added a commit that referenced this issue Mar 21, 2024
@tatiana
Enable append_env in operator_args by default
bbc3953 
The default behaviour when parsing Cosmos DAGs is to use the system environment variables, but to execute dbt
commands from Airflow operators is not. This PR solves this, making the behaviour consistent in DAG parsing
and dbt command execution.

Closes: #595
tatiana added a commit that referenced this issue Mar 25, 2024
@tatiana
Enable append_env in operator_args by default (#899)
d2672b8 
The default behaviour when parsing Cosmos DAGs is to use the system
environment variables, but to execute dbt commands from Airflow
operators is not. This PR solves this, making the behaviour consistent
in DAG parsing and dbt command execution.

Closes: #595
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this issue Jul 14, 2024
@tatiana @arojasb3
Enable append_env in operator_args by default (astronomer#899)
39c6740 
The default behaviour when parsing Cosmos DAGs is to use the system
environment variables, but to execute dbt commands from Airflow
operators is not. This PR solves this, making the behaviour consistent
in DAG parsing and dbt command execution.

Closes: astronomer#595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc good first issue Good for newcomers priority:high High priority issues are blocking or critical issues without a workaround and large impact
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Enable append_env in operator_args by default astronomer/astronomer-cosmos
1 participant
@tatiana