Fix Airflow 2.10 regression and Add Airflow 2.10 in test matrix #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajastro
force-pushed
the
test-af-2.10
branch
from
9d11493
to
4c108d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 96.35% 96.09% -0.26%
==========================================
Files 64 64
Lines 3568 3638 +70
==========================================
+ Hits 3438 3496 +58
- Misses 130 142 +12 ☔ View full report in Codecov by Sentry. |
1 task
2 tasks
dwreeves
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Can you check #1163 before merging? I think that #1163 has a fix that is a little simpler and more robust. (Note that my PR points to your branch, not main, so merging my PR merges to test-af-2.10. I based my PR off your PR especially with the changes to the CI + hatch env.) Let me know what you think.
(It also fixes an issue that's been annoying me for a while, which is that the Mixins needed lots of type: ignores. 😆)
pankajastro
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Description Fixes Airflow 2.10 regression / compat ## Related Issue(s) This is a fix for #1161, and is designed to be a different proposal to the changes in #1162. Ultimately the issue that popped up in 2.10 relates to how the MRO was impacted by the Mixin class. The simplest, most robust fix to make the MRO work properly is to make each mixin a subclass of `BaseOperator`. This doesn't require the unintuitive hack of needing an `__init__()` call to shuffle the MRO around, and it makes things more easily maintainable going forward, I think. A note: This PR is merging to `test-af-2.10`, not `main`. Tested for 2.10. I also removed an unnecessary `__init__` for the `DbtTestMixin` while I was at it. ## Checklist - [x] I have made corresponding changes to the documentation (if required) - [x] I have added tests that prove my fix is effective or that my feature works
|
@pankajastro I force pushed away my change, sorry for wasting time! |
dwreeves
approved these changes
Aug 19, 2024
pankajkoti
approved these changes
Aug 19, 2024
|
Can we create a ticket for this in our repo/board for tracking the work done here and link it in the description? |
pankajkoti
reviewed
Aug 19, 2024
pankajastro
changed the title
dosubot
bot
added
size:L
Co-authored-by: Pankaj Koti <[email protected]>
Merged
pankajkoti
added a commit
that referenced
this pull request
Aug 20, 2024
New Features * Add support for loading manifest from cloud stores using Airflow Object Storage by @pankajkoti in #1109 * Cache ``package-lock.yml`` file by @pankajastro in #1086 * Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana in #1079 * Add support to store and fetch ``dbt ls`` cache in remote stores by @pankajkoti in #1147 * Add default source nodes rendering by @arojasb3 in #1107 * Add Teradata ``ProfileMapping`` by @sc250072 in #1077 Enhancements * Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091 * Use ``dbt ls`` as the default parser when ``profile_config`` is provided by @pankajastro in #1101 * Add task owner to dbt operators by @wornjs in #1082 * Extend Cosmos custom selector to support + when using paths and tags by @mvictoria in #1150 * Simplify logging by @dwreeves in #1108 Bug fixes * Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in #1088 * Fix empty tag in case of custom parser by @pankajastro in #1100 * Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use ``ProjectConfig.dbt_vars`` by @tatiana in #1114 * Fix import handling by lazy loading hooks introduced in PR #1109 by @dwreeves in #1132 * Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by @pankajastro in #1162 Docs * Fix typo in azure-container-instance docs by @pankajastro in #1106 * Use Airflow trademark as it has been registered by @pankajastro in #1105 Others * Run some example DAGs in Kubernetes execution mode in CI by @pankajastro in #1127 * Install requirements.txt by default during dev env spin up by @@CorsettiS in #1099 * Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111 * Disable test for Airflow-2.5 and Python-3.11 combination in CI by @pankajastro in #1124 * Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154, #1167 --------- Co-authored-by: Pankaj Koti <[email protected]> Co-authored-by: Pankaj Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few classes that lack an
__init__method, and their parent class is BaseOperator. These classes are failing to load due to changes introduced in the PR: apache/airflow#41085.I'm adding
__init__at missing places in this PR and also adding Airflow 2.10 in our test matrixCI: https://github.com/astronomer/astronomer-cosmos/actions/runs/10469548488
closes: #1166
closes: #1165