Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS]: Adds Welcome Section and "What Is Cosmos" Blurb to Home Page #1251
base: main
Are you sure you want to change the base?
[DOCS]: Adds Welcome Section and "What Is Cosmos" Blurb to Home Page #1251
Changes from 6 commits
8014500
2129294
61ab4dc
bc8d510
62ee76a
46c8981
61fa25d
a15f5db
cdfd348
555fbb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use "Dbt-core" instead of "dbt"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tatiana / @pankajkoti any thoughts ^^?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not too sure. Maybe we could add a line somewhere that in general when we mean
dbt
, we're referring todbt-core
workflows throughout the references. no strong opinion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wydt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried that, it didn't render (I assume because it wasn't in version control yet). What's the difference between this, and using the relative path so that also works locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they’re just alternatives to each other. I maybe wrong wrt rst syntax, however, I would consider
/_static/jaffle_shop_dbt_graph.png
to be an absolute path, and I’m unsure how that works :). I’m wondering if the correct relative path should be./_static/jaffle_shop_dbt_graph.png
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I initially tried
https://raw.githubusercontent.com/astronomer/astronomer-cosmos/main/docs/_static/jaffle_shop_dbt_graph.png
, I received an error. Intuitively that made sense since the image is new, and does not exist on the main branch.I then tried
./_static/jaffle_shop_dbt_graph.png
, and received the same error. Last attempt was/_static/jaffle_shop_dbt_graph.png
, and the docs compiled properly.As written, the image shows up in the PR preview environment. See here - it's the image for the dbt lineage graph. I'm fine with switching to pulling the image from github main branch if that is what you want, but it means that this PR won't work until after the PR has been merged to main.