-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile name override #314
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 88.43% 88.85% +0.41%
==========================================
Files 41 41
Lines 1280 1292 +12
==========================================
+ Hits 1132 1148 +16
+ Misses 148 144 -4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlaneve thanks. I left some minor comments inline!
Would this change also make sense in other execution modes (e.g. Docker and K8s)?
What happens, ATM, if the user passes this parameter to the DAG and the user is using one of these alternative execution modes?
@tatiana ready for re-review! I addressed all your comments. This doesn't make sense to include for Docker and Kubernetes, since we don't do any profile mapping for those. If you pass in this parameter with those arguments, the DAG won't parse and it'll give you a clear error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @jlaneve!
Description
This PR allows a user to specify a
profile_name_override
. When specified, the profile Cosmos generates will be called the value passed.Related Issue(s)
closes #266
Breaking Change?
Checklist