Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tilt for docker compose in the contributing docs #355

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

CorsettiS
Copy link
Contributor

Description

From my personal experience using tilt, it did not work locally, while the classic docker compose command worked fine. I would suggest to change it to docker compose to simplify development, although it is understandable if the project wants to stick with tilt since it should, in theory simplify some of the overhead.

Related Issue(s)

this is a fix for a issue I was facing #342

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@CorsettiS CorsettiS requested a review from a team as a code owner June 30, 2023 10:39
@CorsettiS CorsettiS requested a review from a team June 30, 2023 10:39
@netlify
Copy link

netlify bot commented Jun 30, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 19c1cba
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/649eb0ee5955520008e57af9

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (35293aa) 88.94% compared to head (19c1cba) 88.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          39       39           
  Lines        1302     1302           
=======================================
  Hits         1158     1158           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! The big thing tilt gives us is the ability to hot rebuild images when you change requirements, etc. But I think the trade off in complexity isn’t worth it, so thank you for putting this PR together.

@jlaneve jlaneve merged commit 949c185 into astronomer:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants