Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ [pre-commit.ci] pre-commit autoupdate #358

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner July 3, 2023 23:45
@pre-commit-ci pre-commit-ci bot requested a review from a team July 3, 2023 23:45
@netlify
Copy link

netlify bot commented Jul 3, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit ab56908
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64a531fac68231000775a629

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pre-commit hook change is causing a few errors in our test-suite, such as:

pydantic.errors.PydanticUserError: A non-annotated attribute was detected: `dag_id = <class 'str'>`. All model fields require a type annotation; if `dag_id` is not meant to be a field, you may be able to resolve this error by annotating it as a `ClassVar` or updating `model_config['ignored_types']`.

We need to address those before merging this change.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8cd9ff3) 88.94% compared to head (ab56908) 88.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          39       39           
  Lines        1302     1302           
=======================================
  Hits         1158     1158           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tatiana tatiana self-requested a review July 5, 2023 09:12
@tatiana tatiana merged commit c7294a9 into main Jul 5, 2023
@tatiana tatiana deleted the pre-commit-ci-update-config branch July 5, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants