Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake private key #378

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Conversation

patawan
Copy link
Contributor

@patawan patawan commented Jul 20, 2023

Description

Added new profile mapping for Snowflake User/Private Key authentication. Currently only supports private_key_content from a Snowflake Airflow connection.

Related Issue(s)

Closes #267

Breaking Change?

N/A

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@patawan patawan requested a review from a team as a code owner July 20, 2023 18:05
@patawan patawan requested a review from a team July 20, 2023 18:05
@netlify
Copy link

netlify bot commented Jul 20, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit e6d7d80
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64baa1c13620ac00081f8c5c

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: +0.12 🎉

Comparison is base (f52293e) 90.70% compared to head (e6d7d80) 90.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   90.70%   90.82%   +0.12%     
==========================================
  Files          44       45       +1     
  Lines        1484     1515      +31     
==========================================
+ Hits         1346     1376      +30     
- Misses        138      139       +1     
Impacted Files Coverage Δ
cosmos/profiles/snowflake/user_privatekey.py 96.55% <96.55%> (ø)
cosmos/profiles/__init__.py 92.59% <100.00%> (+0.28%) ⬆️
cosmos/profiles/snowflake/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@patawan
Copy link
Contributor Author

patawan commented Jul 20, 2023

Hmmm trying to figure out how/why codecov dropped so much
Okay now codecov went back up ¯\(ツ)

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks a lot, @patawan . One minor suggestion and we can merge.

cosmos/profiles/snowflake/user_privatekey.py Show resolved Hide resolved
@tatiana tatiana merged commit 8a40537 into astronomer:main Jul 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key-based auth for Snowflake
2 participants