-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user-supplied profiles #390
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 91.46% 91.21% -0.26%
==========================================
Files 48 48
Lines 1664 1684 +20
==========================================
+ Hits 1522 1536 +14
- Misses 142 148 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've successfully run basic_cosmos_dag
from this branch.
Some comments are in line. Given the timelines, I added "major" to the ones I think are more relevant.
Description
This PR extends the
ProfileConfig
interface to support two modes:When using a profile mapping, you can do one of the following:
When using your own profile, you can supply the
path_to_profiles_yml
:Related Issue(s)
closes #336
closes #269
Breaking Change?
This changes the
ProfileConfig
class, which isn't yet user-facing.Checklist