Add default group_id to init params #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 48 48
Lines 1691 1691
=======================================
Hits 1342 1342
Misses 349 349
☔ View full report in Codecov by Sentry. |
tatiana
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Thanks a lot for the contribution, @chrishronek !
At the moment some tests are failing, could you have a look into them?
jlaneve
approved these changes
Jul 27, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description When attempting to override the `group_id` parameter of a DbtTaskGroup, I get the following error: ```text TypeError: __init__() got multiple values for argument 'group_id' ``` ## Related Issue(s) closes #398 ## Breaking Change? There are no breaking changes with this PR ## Checklist - [x] I have made corresponding changes to the documentation (if required) - [x] I have added tests that prove my fix is effective or that my feature works Co-authored-by: Julian LaNeve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to override the
group_idparameter of a DbtTaskGroup, I get the following error:Related Issue(s)
closes #398
Breaking Change?
There are no breaking changes with this PR
Checklist