Ensure safer profile mappings by removing __getattr__ #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 91.25% 91.35% +0.10%
==========================================
Files 48 48
Lines 1692 1689 -3
==========================================
- Hits 1544 1543 -1
+ Misses 148 146 -2
☔ View full report in Codecov by Sentry. |
harels
approved these changes
Jul 27, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description <!-- Add a brief but complete description of the change. --> Before, profile mappings would override `__getattr__` to get the dbt profile value, primarily for convenience. However, this was causing unintended side effects - infinite recursive loops. This PR fixes the issue by removing the `__getattr__` override in favor of being more explicit. ## Related Issue(s) <!-- If this PR closes an issue, you can use a keyword to auto-close. --> <!-- i.e. "closes #0000" --> ## Breaking Change? <!-- If this introduces a breaking change, specify that here. --> No, this is all behind-the-scenes. ## Checklist - [ ] I have made corresponding changes to the documentation (if required) - [ ] I have added tests that prove my fix is effective or that my feature works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, profile mappings would override
__getattr__to get the dbt profile value, primarily for convenience. However, this was causing unintended side effects - infinite recursive loops. This PR fixes the issue by removing the__getattr__override in favor of being more explicit.Related Issue(s)
Breaking Change?
No, this is all behind-the-scenes.
Checklist