Fix bug causing select and exclude filter issues #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
===========================================
- Coverage 91.35% 79.45% -11.91%
===========================================
Files 48 48
Lines 1689 1689
===========================================
- Hits 1543 1342 -201
- Misses 146 347 +201
☔ View full report in Codecov by Sentry. |
jlaneve
approved these changes
Jul 27, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description When `load_method` was set to `LoadMode.CUSTOM`, any `select/exclude` parameters were ineffective. This is because the entire node list was being passed to the `build_airflow_graph` method instead of a filtered list of nodes. ## Related Issue(s) closes #409 ## Breaking Change? No breaking changes with this change ## Checklist - [x] I have made corresponding changes to the documentation (if required) - [ ] I have added tests that prove my fix is effective or that my feature works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
load_methodwas set toLoadMode.CUSTOM, anyselect/excludeparameters were ineffective. This is because the entire node list was being passed to thebuild_airflow_graphmethod instead of a filtered list of nodes.Related Issue(s)
closes #409
Breaking Change?
No breaking changes with this change
Checklist