Allow profiles_yml_filepath to be a str type #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorsettiS
changed the title
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
===========================================
- Coverage 89.99% 79.45% -10.54%
===========================================
Files 48 48
Lines 1689 1689
===========================================
- Hits 1520 1342 -178
- Misses 169 347 +178
☔ View full report in Codecov by Sentry. |
harels
approved these changes
Aug 1, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description
In the documentation of astronomer, user-supplied profiles are defined
as follows
```
from cosmos.config import ProfileConfig
profile_config = ProfileConfig(
profile_name="my_snowflake_profile",
target_name="dev",
profiles_yml_filepath="/path/to/profiles.yml",
)
dag = DbtDag(profile_config=profile_config, ...)
```
however in the code the _profiles_yml_filepath_ crashes if a string is
supplied to it, since it assumes a Path type instead of a str type. In
the code logic, **self.profiles_yml_filepath.exists()** crashes if the
profiles_yml_filepath is a str. this PR just makes a few adjustment to
allow users to supply a custom filepath in a string format without
having to wrap it over a Path()
## Related Issue(s)
---
## Breaking Change?
No
## Checklist
- [X] I have made corresponding changes to the documentation (if
required)
- [ ] I have added tests that prove my fix is effective or that my
feature works
---------
Co-authored-by: giovanni.corsetti <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Harel Shein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the documentation of astronomer, user-supplied profiles are defined as follows
however in the code the profiles_yml_filepath crashes if a string is supplied to it, since it assumes a Path type instead of a str type. In the code logic, self.profiles_yml_filepath.exists() crashes if the profiles_yml_filepath is a str. this PR just makes a few adjustment to allow users to supply a custom filepath in a string format without having to wrap it over a Path()
Related Issue(s)
Breaking Change?
No
Checklist