Resolving "Crash when adding sources.yml" #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 48 48
Lines 1689 1690 +1
=======================================
+ Hits 1543 1544 +1
Misses 146 146
☔ View full report in Codecov by Sentry. |
abhi12mohan
force-pushed
the
sources-crash
branch
from
3199cf9
to
b1e3dce
Compare
abhi12mohan
force-pushed
the
sources-crash
branch
from
3389751
to
05c7a3a
Compare
jlaneve
approved these changes
Aug 1, 2023
tatiana
reviewed
Aug 7, 2023
There was a problem hiding this comment.
@abhi12mohan, we need to add some automated tests to make sure we don't re-introduce this issue in the future (having a sources.yml file). I see the change was already merged. Could you add this in a separate PR, please?
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description Simply adds "source" as a DbtResourceType. ## Checklist - [ ] I have made corresponding changes to the documentation (if required) - [ ] I have added tests that prove my fix is effective or that my feature works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply adds "source" as a DbtResourceType.
Checklist