-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OAuth authentication for Big Query #431
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
===========================================
- Coverage 91.28% 79.60% -11.69%
===========================================
Files 48 49 +1
Lines 1699 1711 +12
===========================================
- Hits 1551 1362 -189
- Misses 148 349 +201
☔ View full report in Codecov by Sentry. |
@jlaneve The tests are failing with:
This PR does not alter anything related to Are you aware of a test bug of some sorts that has creeped in and if there is a PR already in the work for the same? I hope I am missing something obvious 😢 Thanks! |
Unfortunately this is a known issue when there are PRs from forked repos because CI secrets don’t get set. As long as the unit tests and pre-commit checks pass, we can merge this! It looks like there’s just one minor issue with the pre-commit checks - one of the lines is too long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thank you so much @MonideepDe!
## Description Support OAuth authentication for Big Query ## Related Issue(s) closes #420 ## Breaking Change? None ## Checklist - [ ] I have made corresponding changes to the documentation (if required) - [X] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: Monideep De <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Enhancements * Improve logs to include astornomer-cosmos identifier by @tatiana in #450 * Support OAuth authentication for Big Query by @MonideepDe in #431 Bug fixes * Fix selector for config tags by @javihernovoa in #441 * Fix BigQuery keyfile_dict mapping for connection created from webserver UI by @jbandoro in #449 Others * [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #446 * Resolve MyPy errors when adding Airflow pre-commit dependency by @abhi12mohan in #434
Enhancements * Improve logs to include astronomer-cosmos identifier by @tatiana in #450 * Support OAuth authentication for Big Query by @MonideepDe in #431 Bug fixes * Fix selector for config tags by @javihernovoa in #441 * Fix BigQuery keyfile_dict mapping for connection created from webserver UI by @jbandoro in #449 Others * [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #446 * Resolve MyPy errors when adding Airflow pre-commit dependency by @abhi12mohan in #434
Description
Support OAuth authentication for Big Query
Related Issue(s)
closes #420
Breaking Change?
None
Checklist