Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated import statement #454

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix outdated import statement #454

merged 2 commits into from
Aug 10, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Aug 10, 2023

Before 1.0 this was valid:

    from cosmos.task_group import DbtTaskGroup

Now we expect users to do:

    from cosmos import DbtTaskGroup

Before 1.0 this was valid:
    from cosmos.task_group import DbtTaskGroup

Now we expect users to do:
    from cosmos import DbtTaskGroup
@netlify
Copy link

netlify bot commented Aug 10, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit b61f732
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64d4dd403a069e0008ad9682

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bebe8b0) 90.12% compared to head (b61f732) 90.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          50       50           
  Lines        1752     1752           
=======================================
  Hits         1579     1579           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana marked this pull request as ready for review August 10, 2023 12:51
@tatiana tatiana requested a review from a team as a code owner August 10, 2023 12:51
@tatiana tatiana requested a review from a team August 10, 2023 12:51
@tatiana tatiana merged commit 138aee8 into main Aug 10, 2023
39 checks passed
@tatiana tatiana deleted the docs branch August 10, 2023 12:59
tatiana added a commit that referenced this pull request Aug 10, 2023
Before 1.0 this was valid:

```
    from cosmos.task_group import DbtTaskGroup
```

Now we expect users to do:
```
    from cosmos import DbtTaskGroup
```
@tatiana tatiana added this to the 1.1.0 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants