Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI tests runtime #457

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Improve CI tests runtime #457

merged 7 commits into from
Aug 14, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Aug 11, 2023

Before, Cosmos CI took approximately 18m 7s to run its tests since it did not cache the dependencies.

Configure cache so the CI workers do not have to install all pip dependencies at each CI job run.

Reduces test runtime to approximately 12m-14m, resulting in ~ 20-30% time savings to run tests in the CI.

@netlify
Copy link

netlify bot commented Aug 11, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 3e58da4
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64da47a00fb771000880db06

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +12.27% 🎉

Comparison is base (5c68ed7) 79.24% compared to head (3e58da4) 91.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #457       +/-   ##
===========================================
+ Coverage   79.24%   91.51%   +12.27%     
===========================================
  Files          50       50               
  Lines        1768     1768               
===========================================
+ Hits         1401     1618      +217     
+ Misses        367      150      -217     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana marked this pull request as ready for review August 14, 2023 11:39
@tatiana tatiana requested a review from a team as a code owner August 14, 2023 11:39
@tatiana tatiana requested a review from a team August 14, 2023 11:39
@tatiana tatiana temporarily deployed to internal August 14, 2023 15:24 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to internal August 14, 2023 15:26 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to internal August 14, 2023 17:15 Inactive
@tatiana tatiana merged commit 3be1b27 into main Aug 14, 2023
40 checks passed
@tatiana tatiana deleted the improve-ci-test-time branch August 14, 2023 20:04
tatiana added a commit that referenced this pull request Aug 16, 2023
Feature (pending documentation!)
* Support dbt global flags (via dbt_cmd_global_flags in `operator_args` by @tatiana in #469

Enhancements
* Hide sensitive field when using BigQuery keyfile_dict profile mapping by @jbandoro in #471

Bug fixes
* Fix bug on select node add exclude selector subset ids logic by @jensenity in #463
* Refactor dbt ls to run from a temporary directory, to avoid Read-only file system errors during DAG parsing, by @tatiana in #414

Others
* Docs: Fix RenderConfig load argument by @jbandoro in #466
* Enable CI integration tests from external forks by @tatiana in #458
* Improve CI tests runtime by @tatiana in #457
* Change CI to run coverage after tests pass by @tatiana in #461
* Fix forks code revision in code coverage by @tatiana in #472
* [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #467"
i
@tatiana tatiana mentioned this pull request Aug 16, 2023
@tatiana tatiana added this to the 1.1.0 milestone Aug 16, 2023
@tatiana tatiana mentioned this pull request Sep 6, 2023
tatiana added a commit that referenced this pull request Sep 6, 2023
**Features**

* Support dbt global flags (via dbt_cmd_global_flags in operator_args)
by @tatiana in #469
* Support parsing DAGs when there are no connections by @jlaneve in #489

**Enhancements**

* Hide sensitive field when using BigQuery keyfile_dict profile mapping
by @jbandoro in #471
* Consistent Airflow Dataset URIs, inlets and outlets with `Openlineage
package <https://pypi.org/project/openlineage-integration-common/>`_ by
@tatiana in #485. `Read more
<https://astronomer.github.io/astronomer-cosmos/configuration/lineage.html>`_.
* Refactor ``LoadMethod.DBT_LS`` to run from a temporary directory with
symbolic links by @tatiana in #488
* Run ``dbt deps`` when using ``LoadMethod.DBT_LS`` by @DanMawdsleyBA in
#481
* Update Cosmos log color to purple by @harels in #494
* Change operators to log ``dbt`` commands output as opposed to
recording to XCom by @tatiana in #513

**Bug fixes**

* Fix bug on select node add exclude selector subset ids logic by
@jensenity in #463
* Refactor dbt ls to run from a temporary directory, to avoid Read-only
file system errors during DAG parsing, by @tatiana in #414
* Fix profile_config arg in DbtKubernetesBaseOperator by @david-mag in
#505
* Fix SnowflakePrivateKeyPemProfileMapping private_key reference by
@nacpacheco in #501
* Fix incorrect temporary directory creation in VirtualenvOperator init
by @tatiana in #500
* Fix log propagation issue by @tatiana in #498
* Fix PostgresUserPasswordProfileMapping to retrieve port from
connection by @jlneve in #511

**Others**

* Docs: Fix RenderConfig load argument by @jbandoro in #466
* Enable CI integration tests from external forks by @tatiana in #458
* Improve CI tests runtime by @tatiana in #457
* Change CI to run coverage after tests pass by @tatiana in #461
* Fix forks code revision in code coverage by @tatiana in #472
* [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #467
* Drop support to Python 3.7 in the CI test matrix by @harels in #490
* Add Airflow 2.7 to the CI test matrix by @tatiana in #487
* Add MyPy type checks to CI since we exceeded pre-commit disk quota
usage by @tatiana in #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants