Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to apache-airflow-providers-cncf-kubernetes < 7.4.0 #553

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Add support to apache-airflow-providers-cncf-kubernetes < 7.4.0 #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
802e8b8
Add support to apache-airflow-providers-cncf-kubernetes < 7.4.0
tatiana Sep 26, 2023
0f14ad0
Rollback to raise exception
tatiana Sep 26, 2023
5225716
Merge branch 'main' into support-older-k8s-provider-lower
tatiana Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cosmos/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@

from cosmos.airflow.dag import DbtDag
from cosmos.airflow.task_group import DbtTaskGroup
from cosmos.constants import LoadMode, TestBehavior, ExecutionMode
from cosmos.operators.lazy_load import MissingPackage
from cosmos.config import (
ProjectConfig,
ProfileConfig,
ExecutionConfig,
RenderConfig,
)

from cosmos.constants import LoadMode, TestBehavior, ExecutionMode
from cosmos.log import get_logger
from cosmos.operators.lazy_load import MissingPackage
from cosmos.operators.local import (
DbtDepsLocalOperator,
DbtLSLocalOperator,
Expand All @@ -28,6 +28,8 @@
DbtTestLocalOperator,
)

logger = get_logger()

try:
from cosmos.operators.docker import (
DbtLSDockerOperator,
Expand Down Expand Up @@ -57,7 +59,8 @@
DbtSnapshotKubernetesOperator,
DbtTestKubernetesOperator,
)
except ImportError:
except ImportError as error:
logger.exception(error)
DbtLSKubernetesOperator = MissingPackage(
"cosmos.operators.kubernetes.DbtLSKubernetesOperator",
"kubernetes",
Expand Down
15 changes: 10 additions & 5 deletions cosmos/operators/kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,22 @@

logger = get_logger(__name__)

# kubernetes is an optional dependency, so we need to check if it's installed
try:
# apache-airflow-providers-cncf-kubernetes >= 7.4.0
from airflow.providers.cncf.kubernetes.backcompat.backwards_compat_converters import (
convert_env_vars,
)
from airflow.providers.cncf.kubernetes.operators.pod import KubernetesPodOperator
except ImportError:
raise ImportError(
"Could not import KubernetesPodOperator. Ensure you've installed the Kubernetes provider "
"separately or with with `pip install astronomer-cosmos[...,kubernetes]`."
)
try:
# apache-airflow-providers-cncf-kubernetes < 7.4.0
from airflow.providers.cncf.kubernetes.operators.kubernetes_pod import KubernetesPodOperator
except ImportError as error:
logger.exception(error)
raise ImportError(
"Could not import KubernetesPodOperator. Ensure you've installed the Kubernetes provider "
"separately or with with `pip install astronomer-cosmos[...,kubernetes]`."
)


class DbtKubernetesBaseOperator(KubernetesPodOperator, DbtBaseOperator): # type: ignore
Expand Down
Loading