Fix ExecutionMode.KUBERNETES on Cosmos 1.x #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 92.41% 92.47% +0.05%
==========================================
Files 49 49
Lines 1952 1954 +2
==========================================
+ Hits 1804 1807 +3
+ Misses 148 147 -1
☔ View full report in Codecov by Sentry. |
This was referenced Sep 26, 2023
harels
approved these changes
Sep 27, 2023
2 tasks
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Fix behaviour when using `ExecutionMode.KUBERNETES`, broken between the Cosmos releases 1.0.0 and 1.1.1. Update the documentation to be representative of the 1.x Cosmos interface: https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html Add unit tests to avoid regressions on these fixes. Part of the documentation fixes are made in: astronomer/cosmos-example#4 As a next step, we must ensure integration tests for running Cosmos on K8s to avoid this breaking change moving forward (issue #535). Closes: #493 Closes: #548 Closes: #534 Co-authored-by: Pádraic Slattery <[email protected]>
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using ``ExecutionMode.KUBERNETES`` by @pgoslatara and @tatiana in #554 * Add support to ``apache-airflow-providers-cncf-kubernetes < 7.4.0`` by @tatiana in #553 * Improve error message in ``config.py`` by @meyobagero in #532 * Use ``returncode`` instead of ``stderr`` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Fix only create task group and test task only if model has test by @raffifu in #543 * Fix ``on_warning_callback`` behaviour on ``DbtTestLocalOperator`` by @edgga, @marco9663 and @tatiana in #558 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @tatiana in #558 * Fix ``target-path`` not specified issue in ``dbt-project.yml`` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Closed
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Fix behaviour when using `ExecutionMode.KUBERNETES`, broken between the Cosmos releases 1.0.0 and 1.1.1. Update the documentation to be representative of the 1.x Cosmos interface: https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html Add unit tests to avoid regressions on these fixes. Part of the documentation fixes are made in: astronomer/cosmos-example#4 As a next step, we must ensure integration tests for running Cosmos on K8s to avoid this breaking change moving forward (issue #535). Closes: #493 Closes: #548 Closes: #534 Co-authored-by: Pádraic Slattery <[email protected]>
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Improve error message in `config.py` by @meyobagero in #532 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546 (cherry picked from commit 427f713)
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546 (cherry picked from commit 427f713) (cherry picked from commit 61e4460)
Merged
tatiana
added a commit
that referenced
this pull request
Sep 28, 2023
This PR is a subset of the actual Release 1.1.2 (#560), since - for this release - we had to revert a [commit](#560 (comment)) which we don't intend to revert on the project's main branch. Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix behaviour when using
ExecutionMode.KUBERNETES, broken between the Cosmos releases 1.0.0 and 1.1.1.Update the documentation to be representative of the 1.x Cosmos interface:
https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html
Add unit tests to avoid regressions on these fixes.
Part of the documentation fixes are made in: astronomer/cosmos-example#4
As a next step, we must ensure integration tests for running Cosmos on K8s to avoid this breaking change moving forward (issue #535).
Closes: #493
Closes: #548
Closes: #534
Co-authored-by: Pádraic Slattery [email protected] (who created PR #551)