Fix custom selector when select has a subset of tags of the models' tags #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tags and config.tags to be identical (usually the case) - add consistency with has_child and is_child tag for non-test nodes
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
tatiana
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Thanks, @david-mag , it looks good - happy to merge once the checks pass!
|
@tatiana Not sure whats the issue exactly, but the error msg in the failed test returns this: So could it be that the integration test itself has an issue? I'm not aware of any changes regarding access tokens in my PR. 😅 |
|
Hey @david-mag , yes I noticed this earlier today - it seems there is an issue with the token. I will look into this within a few hours! |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 51 51
Lines 2053 2053
=======================================
Hits 1912 1912
Misses 141 141
☔ View full report in Codecov by Sentry. |
tatiana
changed the title
tatiana
approved these changes
Oct 17, 2023
tatiana
pushed a commit
that referenced
this pull request
Oct 25, 2023
…ags (#606) Before, when using Cosmos custom selector, it expected an exact match of all *tags*. Example: `model1` with tags `tag1` and `tag2` would only be selected/excluded if the select/exclude statement in the `RenderConfig` was set to `select=["tag:tag1,tag:tag2"]`. It would not be selected if the `RenderConfig` had `select=["tag:tag1"]` or `select=["tag:tag2"]` only. (cherry picked from commit a433f15)
tatiana
added a commit
that referenced
this pull request
Oct 25, 2023
Bug fixes * Resolve errors occurring when `dbt_project_path` is str and partial support `dbt_project_path=None` by @MrBones757 in #605 * Fix running dbt tests that depend on multiple models (support `--indirect-selection` buildable) by @david-mag in #613 * Add tests to sources, snapshots and seeds when using `TestBehavior.AFTER_EACH` by @tatiana in #599 * Fix custom selector when select has a subset of tags of the models' tags by @david-mag in #606 Others * Update contributing guide docs by @raffifu in #591 * Fix running test that validates manifest-based DAGs by @tatiana in #619 * pre-commit updates in #604 and #621
tatiana
added a commit
that referenced
this pull request
Oct 25, 2023
Bug fixes * Resolve errors occurring when `dbt_project_path` is str and partial support `dbt_project_path=None` by @MrBones757 in #605 * Fix running dbt tests that depend on multiple models (support `--indirect-selection` buildable) by @david-mag in #613 * Add tests to sources, snapshots and seeds when using `TestBehavior.AFTER_EACH` by @tatiana in #599 * Fix custom selector when select has a subset of tags of the models' tags by @david-mag in #606 Others * Update contributing guide docs by @raffifu in #591 * Fix running test that validates manifest-based DAGs by @tatiana in #619 * pre-commit updates in #604 and #621 (cherry picked from commit 52c34a2)
tatiana
added a commit
that referenced
this pull request
Oct 25, 2023
Bug fixes * Resolve errors occurring when `dbt_project_path` is str and partial support `dbt_project_path=None` by @MrBones757 in #605 * Fix running dbt tests that depend on multiple models (support `--indirect-selection` buildable) by @david-mag in #613 * Add tests to sources, snapshots and seeds when using `TestBehavior.AFTER_EACH` by @tatiana in #599 * Fix custom selector when select has a subset of tags of the models' tags by @david-mag in #606 * Fix `LoadMode.AUTOMATIC` behaviour to use `LoadMode.DBT_LS` when `ProfileMapping` is used by @tatiana in #625 * Fix failure if `openlineage-common` raises a jinja exception by @tatiana in #626 Others * Update contributing guide docs by @raffifu in #591 * Remove unnecessary stack trace from Cosmos initialization by @tatiana in #624 * Fix running test that validates manifest-based DAGs by @tatiana in #619 * pre-commit updates in #604 and #621
tatiana
added a commit
that referenced
this pull request
Oct 25, 2023
Bug fixes * Resolve errors occurring when `dbt_project_path` is str and partial support `dbt_project_path=None` by @MrBones757 in #605 * Fix running dbt tests that depend on multiple models (support `--indirect-selection` buildable) by @david-mag in #613 * Add tests to sources, snapshots and seeds when using `TestBehavior.AFTER_EACH` by @tatiana in #599 * Fix custom selector when select has a subset of tags of the models' tags by @david-mag in #606 * Fix `LoadMode.AUTOMATIC` behaviour to use `LoadMode.DBT_LS` when `ProfileMapping` is used by @tatiana in #625 * Fix failure if `openlineage-common` raises a jinja exception by @tatiana in #626 Others * Update contributing guide docs by @raffifu in #591 * Remove unnecessary stack trace from Cosmos initialization by @tatiana in #624 * Fix running test that validates manifest-based DAGs by @tatiana in #619 * pre-commit updates in #604 and #621 (cherry picked from commit 635fb7b)
Merged
tatiana
added a commit
that referenced
this pull request
Oct 25, 2023
Bug fixes * Resolve errors occurring when `dbt_project_path` is str and partial support `dbt_project_path=None` by @MrBones757 in #605 * Fix running dbt tests that depend on multiple models (support `--indirect-selection` buildable) by @david-mag in #613 * Add tests to sources, snapshots and seeds when using `TestBehavior.AFTER_EACH` by @tatiana in #599 * Fix custom selector when select has a subset of tags of the models' tags by @david-mag in #606 * Fix `LoadMode.AUTOMATIC` behaviour to use `LoadMode.DBT_LS` when `ProfileMapping` is used by @tatiana in #625 * Fix failure if `openlineage-common` raises a jinja exception by @tatiana in #626 Others * Update contributing guide docs by @raffifu in #591 * Remove unnecessary stack trace from Cosmos initialization by @tatiana in #624 * Fix running test that validates manifest-based DAGs by @tatiana in #619 * pre-commit updates in #604 and #621 (cherry picked from commit 635fb7b)
|
@david-mag We just published the release 1.2.1: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tags filtering (select/exclude) was bugged, expecting a perfect match of all tags set (e.g.
model1with tagstag1andtag2would only be selected/excluded if the select/exclude statement in theRenderConfigis set toselect=["tag:tag1,tag:tag2"], but not if it is set asselect=["tag:tag1"]orselect=["tag:tag2"]only.)Tests were already existing, but the node-setup did not include intersections of tags. I've fixed that and added another test as well.
Checklist