Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python3.7 #88

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Conversation

jbandoro
Copy link
Collaborator

@jbandoro jbandoro commented Jan 20, 2023

Fixes #87

Type hinting updates so can support Python 3.7

Ran the pre-commit hook which did isort and black updates, but there were a lot of E501 Line too long errors that I ignored.

@jbandoro jbandoro requested a review from a team as a code owner January 20, 2023 23:25
@chrishronek chrishronek added bug Something isn't working customer request An Astronomer customer made requested this labels Jan 21, 2023
Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jbandoro! Very much appreciated.

Just left a small comment around adding typing_extensions to the pyproject.toml requirements. We use Hatch as a build system, and there's docs here around how to use environment markers to only install if the Python version <= 3.7.

cosmos/providers/dbt/dag.py Show resolved Hide resolved
Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! When you merge the PR, I'll release a new version.

Separately - let us know how you like Cosmos! If there's anything missing for your use case, file an issue and we can help work on it. And if you want help setting it up or just want to chat about our plans for Cosmos, feel free to drop me a note at [email protected] 🙂

@jbandoro
Copy link
Collaborator Author

LGTM! When you merge the PR, I'll release a new version.

Separately - let us know how you like Cosmos! If there's anything missing for your use case, file an issue and we can help work on it. And if you want help setting it up or just want to chat about our plans for Cosmos, feel free to drop me a note at [email protected] 🙂

Yeah I saw Cosmos posted on LinkedIn and the ability to parse a DAG from a dbt project is super cool! I wanted to try it out in my team's test environment but we're still using Python 3.7.

I'm going to hold off on merging, since I'm still trying to get a DbtTaskGroup to run from my feature branch, so once I confirm I can get a dbt model parsed and running I'll confirm here or make any needed updates for Python3.7. Thanks!

@jbandoro
Copy link
Collaborator Author

I'm going to hold off on merging, since I'm still trying to get a DbtTaskGroup to run from my feature branch, so once I confirm I can get a dbt model parsed and running I'll confirm here or make any needed updates for Python3.7. Thanks!

Got a dbt dag to run with python 3.7 🥳, the commit above was the only issue for unioning 2 dictionaries in python < 3.9 - thanks for your team's work on cosmos it's really cool!

@jbandoro
Copy link
Collaborator Author

Also I can't merge in this repo, so please go ahead if the update looks good.

@jlaneve jlaneve merged commit 5e8780a into astronomer:main Jan 21, 2023
tatiana added a commit that referenced this pull request Dec 5, 2023
[Justin Bandoro](https://www.linkedin.com/in/justin-bandoro-592b14a7/)
(@jbandoro) is a Data Engineer at Kevala Inc. He's based in San
Francisco (USA) and has been an early adopter of Cosmos, using it
regularly at his company.

Not only has he been using Cosmos since the early stages, but he has
consistently improved Cosmos since January 2023:
![Screenshot 2023-12-04 at 16 28
29](https://github.com/astronomer/astronomer-cosmos/assets/272048/43197938-d1ab-431f-b101-b6026e5cd3ab)

Some of his contributions include new features, code quality,
documentation and overall improvements. Some examples:
* Speed up integration tests in 67% #732 
* Prevent override of dbt profile fields #702
* Add support for env vars in `RenderConfig` in #690 
* Use symbolic links to run local tasks, avoiding to copy potentially
huge dbt project folders in #660
* Improve documentation in #638
* Automated and improved the code complexity checks in #629
* Added `DbtDocsGCSOperator` in #616 
* Added support for Python 3.7 in #88 and #214

Additionally, he has been interacting with users in the #airflow-dbt
Slack channel in a very collaborative and supportive way.

We want to promote him as a Cosmos committer and maintainer for all
these, recognising his constant efforts and achievements towards our
community. Thank you very much, @jbandoro !
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
[Justin Bandoro](https://www.linkedin.com/in/justin-bandoro-592b14a7/)
(@jbandoro) is a Data Engineer at Kevala Inc. He's based in San
Francisco (USA) and has been an early adopter of Cosmos, using it
regularly at his company.

Not only has he been using Cosmos since the early stages, but he has
consistently improved Cosmos since January 2023:
![Screenshot 2023-12-04 at 16 28
29](https://github.com/astronomer/astronomer-cosmos/assets/272048/43197938-d1ab-431f-b101-b6026e5cd3ab)

Some of his contributions include new features, code quality,
documentation and overall improvements. Some examples:
* Speed up integration tests in 67% astronomer#732 
* Prevent override of dbt profile fields astronomer#702
* Add support for env vars in `RenderConfig` in astronomer#690 
* Use symbolic links to run local tasks, avoiding to copy potentially
huge dbt project folders in astronomer#660
* Improve documentation in astronomer#638
* Automated and improved the code complexity checks in astronomer#629
* Added `DbtDocsGCSOperator` in astronomer#616 
* Added support for Python 3.7 in astronomer#88 and astronomer#214

Additionally, he has been interacting with users in the #airflow-dbt
Slack channel in a very collaborative and supportive way.

We want to promote him as a Cosmos committer and maintainer for all
these, recognising his constant efforts and achievements towards our
community. Thank you very much, @jbandoro !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer request An Astronomer customer made requested this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.7 is not supported
3 participants