Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dbt_tags parameter to general select parameter #96

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Convert dbt_tags parameter to general select parameter #96

merged 5 commits into from
Jan 25, 2023

Conversation

chrishronek
Copy link
Contributor

Closes 94

I also snuck in there a max line length of 120 so that pre-commit stopped failing.

@chrishronek chrishronek added the enhancement New feature or request label Jan 24, 2023
@chrishronek chrishronek self-assigned this Jan 24, 2023
@chrishronek chrishronek requested a review from a team as a code owner January 24, 2023 23:31
@chrishronek chrishronek marked this pull request as draft January 24, 2023 23:53
@chrishronek chrishronek marked this pull request as ready for review January 25, 2023 00:01
jlaneve
jlaneve reviewed Jan 25, 2023
View reviewed changes
cosmos/providers/dbt/dag.py Outdated Show resolved Hide resolved
cosmos/providers/dbt/render.py Outdated Show resolved Hide resolved
cosmos/providers/dbt/task_group.py Outdated Show resolved Hide resolved
jlaneve
jlaneve approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small comment about where the exclude/select check is, but after that's addressed feel free to merge!

cosmos/providers/dbt/render.py Outdated Show resolved Hide resolved
@chrishronek chrishronek merged commit b4ea9e6 into main Jan 25, 2023
@chrishronek chrishronek deleted the tags-issue-94 branch January 25, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaneve jlaneve jlaneve approved these changes

Assignees

@chrishronek chrishronek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for "tags" select/exclude to DbtDag & DbtTaskGroup parsers
2 participants
@chrishronek @jlaneve