change asdf.tests.helpers use to asdf.testing.helpers #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdf.tests.helpers is being deprecated in: asdf-format/asdf#1440
braingram
added a commit
to braingram/specutils
that referenced
this pull request
Feb 23, 2023
asdf.tests.helpers will be deprecated: astropy/asdf-astropy#168 The uses in specutils are limited to assert_roundtrip_tree A similar roundtrip_object exists in asdf.testing.helpers which serializes then deserializes an object (without asserting equality). This commit replaces the uses of assert_roundtrip_tree with roundtrip_object and uses the equality comparison built into the custom asdf types implemented in this module to check for equality. These equality comparisons are the same checks that were used internally by assert_roundtrip_tree.
braingram
added a commit
to braingram/specutils
that referenced
this pull request
Feb 23, 2023
asdf.tests.helpers will be deprecated: astropy/asdf-astropy#168 The uses in specutils are limited to assert_roundtrip_tree A similar roundtrip_object exists in asdf.testing.helpers which serializes then deserializes an object (without asserting equality). This commit replaces the uses of assert_roundtrip_tree with roundtrip_object and uses the equality comparison built into the custom asdf types implemented in this module to check for equality. These equality comparisons are the same checks that were used internally by assert_roundtrip_tree.
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 55 55
Lines 2001 2003 +2
=======================================
+ Hits 1989 1991 +2
Misses 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WilliamJamieson
approved these changes
Feb 23, 2023
|
@braingram these changes look good. Mark this as "Ready for review" if you are happy with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asdf.tests.helpers is being deprecated in:
asdf-format/asdf#1440
This PR updates the uses of asdf.tests.yaml_to_asdf to use asdf.testing.yaml_to_asdf.