Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quantities notebook #449

Merged
merged 5 commits into from
May 18, 2020
Merged

Update Quantities notebook #449

merged 5 commits into from
May 18, 2020

Conversation

kakirastern
Copy link
Contributor

Fixes #447.

Update tutorial content to pass CI checks.

@kakirastern
Copy link
Contributor Author

Looks like the quantities notebook is working now but the CI tests are plagued by apparent server-side errors.

@kakirastern kakirastern requested a review from eblur May 3, 2020 08:52
@kakirastern
Copy link
Contributor Author

Will need to try again during Learn Astropy cowork tomorrow...

@eblur eblur mentioned this pull request May 11, 2020
Closed
@adrn
Copy link
Member

adrn commented May 18, 2020 •
edited
Loading

Thanks @kakirastern - could you please clear notebook outputs?

@kakirastern
Copy link
Contributor Author

@adrn You are welcome. Sure, let me do it now...

Update Quantities notebook
5673b0b 
Upate author name in name list

Update ipynb file metadata

Revert name change

Clear notebook output
@adrn adrn merged commit 5e6369e into astropy:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrn adrn adrn left review comments

@eblur eblur Awaiting requested review from eblur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quantities notebook in quarantine
2 participants
@kakirastern @adrn