Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First tutorial in specutils series #491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eblur
Copy link
Contributor

@eblur eblur commented Jul 15, 2021

Part 1 of a specutils tutorial series

How to Load, Plot, and Smooth an Optical Spectrum from SDSS

Ready for review. This is in response to Issue #440

eblur added 2 commits July 8, 2021 11:57
trying to bring my material up-to-date with astropy-tutorials main
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,475 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for calling it xid. Is there a more descriptive variable name we could use?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about crossmatch_id ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants