Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE 22 listing: Adjust to upstream YAML changes #605

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

pllim
Copy link
Member

@pllim pllim commented Jul 11, 2024

Looks like in https://raw.githubusercontent.com/pyOpenSci/pyopensci.github.io/main/_data/packages.yml they changed

  partners:
    - 'astropy'

to

  partners:
    - 'astropy: link-coming soon-to standards'

that caused our parser to fail and result in empty listing. I was expecting one or two packages. This is a follow-up of #590 .

xref pyOpenSci/pyosMeta#186

cc @dhomeier and @hamogu

@pllim pllim marked this pull request as ready for review July 11, 2024 16:38
@pllim
Copy link
Member Author

pllim commented Jul 11, 2024

With this patch, I see 2.

@lwasser
Copy link
Contributor

lwasser commented Jul 11, 2024

Just a note that we will also fix this on our end. i am dangerous with js but a startswith in that list in theory could work. and in the future we will have a test for this on all new pr's. we are still developing pyosMeta!

@pllim pllim merged commit 2c42ec7 into astropy:main Jul 11, 2024
2 checks passed
@pllim pllim deleted the fix-ape22-listing branch July 11, 2024 17:13
@sneakers-the-rat
Copy link
Contributor

sneakers-the-rat commented Jul 11, 2024

Doesn't matter now that its merged, but since u asked for suggestions on the JS in slack, checking for existence of a substring within an array of strings can be done like this :)

let found_astropy = partners.some(e => e.includes("astropy"))

@pllim
Copy link
Member Author

pllim commented Jul 11, 2024

Thanks, I applied your suggestion at #608 and gave you co-author credit. Much more elegant now. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants