This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to use GitHub Actions for CI #449
Add option to use GitHub Actions for CI #449
Changes from 24 commits
8b1a5d7
7b3f717
95bce37
9d3c29d
070f212
16d329b
7e8bf28
6e44fb1
334e177
18fbe15
5664926
90c6fd0
e104a31
64f7fdb
17c03c0
f8c8971
e7d866b
322683b
6e8ca55
c0e1aaf
95675a9
026de85
8497d53
fa6fa76
677370c
da62bd1
d92e94d
f5fde9e
40833b3
7caea3c
2fc7f51
3b016ec
0e47911
88a818e
fd8a4d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also include @saimn 's patch in astropy/astropy#11054 so Actions won't also run on forks when PR is opened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this keeps the template in-line with what astropy is doing so definitely worth including.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone kindly gave me this piece of code to allow for skipping CI. Passing it forward.
if: "!(contains(github.event.head_commit.message, '[skip ci]') || contains(github.event.head_commit.message, '[ci skip]'))"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that still work? It didn't work for me when I tried at astropy/astropy#11044 . In fact, I dumped the whole
github.event
context out and couldn't find anyhead_commit
in it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it recently. It worked when I first added it and doesn't NOT work. But I see 11044 is more recent than my last test, so I guess it doesn't work anymore 👎 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had this in the template originally, but took it out because it's no longer a reliable method of doing this. i would prefer to leave this alone until either it's supported natively (actions/runner#774) or there's an official action published that will do this properly. a 3rd party action exists, https://github.com/marketplace/actions/ci-skip-action, and seems to work well. astropy may wish to make their own version of this if native support is not forthcoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this worked for me in
photutils
when I tested it:https://github.com/astropy/photutils/blob/master/.github/workflows/ci_tests.yml#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no work astropy/photutils#1121