BUG: fix numpy dev version as their versioning system changed #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 52 52
Lines 6035 6035
=======================================
Hits 4828 4828
Misses 1207 1207 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
commented
Aug 16, 2023
| @@ -17,7 +17,7 @@ | |||
| ASTROPY_HEADER = False | |||
|
|
|||
| # Keep this until we require numpy to be >=2.0 | |||
| if minversion(np, "2.0.0.dev0+151"): | |||
| if minversion(np, "2.0.0.dev0+git20230726"): | |||
There was a problem hiding this comment.
I could probably use just the 2.0.0.dev0 tag, but that's technically not correct and could cause failures for the unlikely scenario of someone having an a couple of weeks old dev version. So will just go with this.
bsipocz
added a commit
that referenced
this pull request
Aug 16, 2023
BUG: fix numpy dev version as their versioning system changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy's versioning has changed in numpy/numpy#24196 causing the repr issues we see #479.
This PR fixes #479