fix: author constraint missed rr.res_role extra table #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add a remote test with all constraints
msdemlei
approved these changes
Jan 23, 2024
bsipocz
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thank you so much for the PR. I have a super minimal bikeshedding comment about the changelog for which I added a suggestion here rather than changing it prior the release.
and I suppose we should properly document the practices for changelog at some point (it's user-facing, so it should be informative for them and should summarize what a PR fixed/enabled rather than the "how". And we only list user-related items (no entry for PRs that only touch docs, tests, or internal maintenance)
|
devdeps CI failure is unrelated and upstream due to an astropy/numpy incompatibility |
Co-authored-by: Brigitta Sipőcz <[email protected]>
|
That'd be a useful document, I'm always unsure about what should be in the changelog ^^' |
|
Thanks @ManonMarchand! |
bsipocz
added a commit
that referenced
this pull request
Feb 22, 2024
fix: author constraint missed rr.res_role extra table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR should solve #514. It adds the table
rr.res_roleto the init of the Author constraint.There is also a new remote test that combines every constraint type. This should prevent this kind of issue to come back.