No longer joining alt_identifier into our RegTAP template query. #561
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, we missed it! |
ManonMarchand
approved these changes
Jun 26, 2024
|
On Wed, Jun 26, 2024 at 12:25:17AM -0700, Manon Marchand wrote:
@ManonMarchand approved this pull request.
Thanks! I'd argue this is such a minor bugfix that a changelog entry
is not necessary; and test failures (I'll fix the datalink-related
ones in #559) are unrelated to this change, so I think this is ready
to go.
|
bsipocz
approved these changes
Jun 26, 2024
|
Thanks! Also, @ManonMarchand, please feel free to merge PRs once you approve them, unless there are some remaining discussion/todo items. |
bsipocz
added a commit
that referenced
this pull request
Oct 14, 2024
No longer joining alt_identifier into our RegTAP template query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #560.