Replace deprecated AsdfInFits #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pinning in setup.cfg. Misc import clean-up in test_jwst_reader.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
- Coverage 70.09% 70.05% -0.04%
==========================================
Files 64 64
Lines 4344 4345 +1
==========================================
- Hits 3045 3044 -1
- Misses 1299 1301 +2 ☔ View full report in Codecov by Sentry. |
in numpy 1.25
pllim
force-pushed
the
asdfinfits-giving-me-the-fits
branch
from
5cd969d
to
2954e86
Compare
|
Remaining dev failures in doctest are unrelated. (See #1034) |
This was referenced Mar 13, 2023
rosteen
reviewed
Mar 14, 2023
| sphinx-astropy | ||
| matplotlib | ||
| graphviz | ||
| # TODO: Remove pinning when ndcube fixed | ||
| # See https://github.com/astropy/specutils/issues/1028 | ||
| ndcube<2.1 |
There was a problem hiding this comment.
NDCube 2.1.1 was released with the fix for this, we should be able to remove this pin now.
There was a problem hiding this comment.
No, there is still sunpy/ndcube#604
There was a problem hiding this comment.
Ah, blast. Alright, it stays for now 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
stdatamodelsto test dependencies)np.alltruein numpy 1.25