Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert site to 1224px overall width #148

Closed
dflitner opened this issue Sep 15, 2020 · 4 comments
Closed

Convert site to 1224px overall width #148

dflitner opened this issue Sep 15, 2020 · 4 comments

Comments

@dflitner
Copy link
Contributor

The wireframes assume a page width of 1200px and our current theme is set to about 1110px. ASU Web Standards 2.0 has widths calculated for a variety of breakpoints, that also target bootstrap components for flow at those breakpoints. The base container width is 1224px.

At some point, we should discuss when and how far we want to bring the repository theme into alignment with WS 2.0.

From Sarah Hough at the Hub:

All, I do want to be super clear that the unity design system is flexible as long as the grid, spacing and typography standards are being followed. Solutions have been designed for common needs, like cards, lists, carousels, forms, etc, but that doesn't mean the UI kit is comprehensive of every possible standards-aligned solution. If you have a component needed by your unit that isn't part of it, the hope is that can become part of the kit to benefit the community, or an example of how the standards can be executed beyond the prescribed components.

@elizoller elizoller added this to the Q2 2021 milestone Jan 5, 2021
@elizoller
Copy link
Contributor

@dflitner will we get this with the transition to unity as part of #356 ?

@elizoller
Copy link
Contributor

@dflitner do you if unity bootstrap will do this for us?

@dflitner
Copy link
Contributor Author

Yes, if we use the Unity files, _grid.scss has the containers set to max-width: 1224px for desktop.

@elizoller
Copy link
Contributor

Screen Shot 2021-07-06 at 10 09 11 AM

i believe this is applied now with the inclusion of #408 @dflitner please re-open if this is not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants