Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an implementation of pending stream #615

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Add an implementation of pending stream #615

merged 4 commits into from
Jan 14, 2020

Conversation

lqf96
Copy link
Contributor

@lqf96 lqf96 commented Dec 11, 2019

This pull request adds an implementation of pending stream, which always returns Poll::Pending and never completes. The implementation is largely copy-pasted from futures_util::stream::pending, with trait implementations for DoubleEndedStream, FusedStream and ExactSizeStream added.

yoshuawuyts
yoshuawuyts requested changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks good! Only thing missing is a usage example, and then we should be good to merge!

src/stream/pending.rs Show resolved Hide resolved
k-nasa
k-nasa approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
I think it's perfect to correct yoshua's point.

@k-nasa
Copy link
Member

k-nasa commented Jan 13, 2020

@lqf96
This appears to have stopped.
If you're busy, I'll take over for this.

yoshuawuyts
yoshuawuyts approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 133e30e into async-rs:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@k-nasa k-nasa k-nasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lqf96 @k-nasa @yoshuawuyts