fix: remove obsolete try...catch
#176
Conversation
tsauerwein
requested review from
Souvikns,
aeworxet and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
tsauerwein
force-pushed
the
fail-on-error
branch
from
40d8e2e
to
a2ac491
Compare
tsauerwein
force-pushed
the
fail-on-error
branch
from
a2ac491
to
ce84ad6
Compare
|
I do not normally do Either that use case has already been taken care of, or I will see the same edge case and process it in another way. @Souvikns, this PR looks good to me, but can you please do this simple review only so I'm not reviewing my own code? |
|
/rtm |
|
🎉 This PR is included in version 0.5.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue asyncapi/cli#1475 gives an example where an invalid external reference is ignored, and all other documents are skipped. Instead of silently failing, this PR proposes to let the error propagate.
Related issue(s)
Fixes asyncapi/cli#1475