chore: use typescript type for declaring options #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laupetin
requested review from
Souvikns,
aeworxet and
asyncapi-bot-eve
as code owners
|
You have some conflicts @Laupetin, feel free to resolve them and I will start with reviewing. |
|
This matter is addressed in #188. |
|
Hey thanks, i wont be able to adjust the PR for another week unfortunately. If you want to address it in another PR, feel free to do it there and close this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the options object of the bundler is just declared as
any, despite using typescript.Adding a type for it improves autocompletion when trying to use the bundler as a library in another project and generally improves type recognition in the code.