Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ashmit-coder in Maintainers.yml #1585

Merged

Conversation

ashmit-coder
Copy link
Contributor

Added @ashmit-coder for maintainer of conference-website

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ashmit-coder ashmit-coder changed the title added ashmit-coder in Maintainers.yml feat: added ashmit-coder in Maintainers.yml Nov 11, 2024
@ashmit-coder
Copy link
Contributor Author

Hey @thulieblack , please do verify if any changes need to be made.

@thulieblack
Copy link
Member

It's awesome that you decided to join TSC as well, welcome I couldn't have been more proud

Please watch TSC Onboarding for onboarding

@iambami fyi

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thulieblack
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 31c04b0 into asyncapi:master Nov 11, 2024
25 of 27 checks passed
@derberg
Copy link
Member

derberg commented Nov 12, 2024

hmm you should not be adding yourself manually 🤔
are you in CODEOWNERS file of the related repo? if not, then technically you are not a maintainer @ashmit-coder

@ashmit-coder
Copy link
Contributor Author

hmm you should not be adding yourself manually 🤔
are you in CODEOWNERS file of the related repo? if not, then technically you are not a maintainer @ashmit-coder

Yes @derberg I am in the codeowners of conference-website. I was told to add myself by @thulieblack . As we were having some issues, when my name was added to the codeowners. Would be helpful if you could tell us what to do about it🙂

@thulieblack
Copy link
Member

So the process is now automated; we weren't supposed to do it manually like this. But it's all sorted now 😉

@derberg
Copy link
Member

derberg commented Nov 12, 2024

@ashmit-coder all good now

the most important is that you watch https://www.youtube.com/watch?v=MfVUUbW2aos video now as it is critical to understand what you sign up for as TSC member.

@ashmit-coder
Copy link
Contributor Author

@ashmit-coder all good now

the most important is that you watch https://www.youtube.com/watch?v=MfVUUbW2aos video now as it is critical to understand what you sign up for as TSC member.

Done @derberg!
Looking forward to work on studio and react projects this summer, hope to see you there 🫡

Copy link
Member

derberg commented Nov 12, 2024

awesome, you have a chance to take a first vote as TSC member: #1577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants