Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special cases in enum values fails to generate accurate enum keys for C# generator #503

Closed
jonaslagoni opened this issue Nov 3, 2021 · 5 comments · Fixed by #559
Closed
Labels
bug Something isn't working C# generator Anything related to the C# generator good first issue Good for newcomers released on @next released

Comments

@jonaslagoni
Copy link
Member

Describe the bug

Thanks to @panwauu, we already have it solved in the C# generator, see #450 and fix in #497.

We need to apply the same fix we did here:

key = FormatHelpers.replaceSpecialCharacters(String(value), { exclude: [' '], separator: '_' });

to this line:
let itemName = String(item);

@jonaslagoni jonaslagoni added bug Something isn't working good first issue Good for newcomers C# generator Anything related to the C# generator labels Nov 3, 2021
@ron-debajyoti
Copy link
Contributor

Hi @jonaslagoni , let me take this up and try to solve this issue !

@jonaslagoni
Copy link
Member Author

No need to ask for permission, go right ahead @ron-debajyoti 🙂

@ron-debajyoti
Copy link
Contributor

ron-debajyoti commented Jan 4, 2022

Hi @jonaslagoni !
I followed the same process used in #497. Please review the pull request and the test snapshots I added.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.40.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C# generator Anything related to the C# generator good first issue Good for newcomers released on @next released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants